Zappa icon indicating copy to clipboard operation
Zappa copied to clipboard

dead_letter_arn setting does not get applied

Open nrowland opened this issue 6 years ago • 2 comments

Context

I am trying to update an existing zappa configuration to include a dead letter queue that has already been created elsewhere.

Expected Behavior

"dead_letter_arn" config should properly configure lambda with the referenced dead letter queue configuration

Actual Behavior

Dead Letter configuration in AWS console remains empty.

Possible Fix

The call to boto to update the function configuration does not seem to include dead letter settings - DeadLetterConfig is missing from the boto3 call: response = self.lambda_client.update_function_configuration( FunctionName=function_name, Runtime=runtime, Role=self.credentials_arn, Handler=handler, Description=description, Timeout=timeout, MemorySize=memory_size, VpcConfig=vpc_config, Environment={'Variables': aws_environment_variables}, KMSKeyArn=aws_kms_key_arn, TracingConfig={ 'Mode': 'Active' if self.xray_tracing else 'PassThrough' } )

Steps to Reproduce

  1. update zappa settings to include dead_letter_arn property
  2. call zappa update
  3. observe DLQ is not configured in AWS console

Your Environment

  • Zappa version used: 0.46.2
  • Operating System and Python version: Python 3.6, MaxOSX

nrowland avatar Sep 13 '18 15:09 nrowland

@Miserlou please check this! I have a same issue.

hyunjunian avatar Jun 08 '20 03:06 hyunjunian

@nrowland I would say you can't do just update the instance. You should deploy the instance again. book Here is the screenshot of Book "Building Serverless Python Web Services With Zappa" on page # 247

abdul-basit-bboxx avatar Dec 07 '21 07:12 abdul-basit-bboxx