Miserlou
Replace windows path separator with posix separator in Zip files #1358
Description
Replace windows path separators \ with posix separators /
GitHub Issues
https://github.com/Miserlou/Zappa/issues/1358
Coverage decreased (-15.6%) to 57.177% when pulling 56d477235fbe9ee0012cf0e6c883d7d4ab66eaf1 on aldokkani:master into 6a43ed0b06e5877e71e829686fad93f8e51b78c1 on Miserlou:master.
This would be extremely useful if we could have it pulled in. As a Windows 10 user I am very limited as to what I can do with Zappa as the deployments fail consistently due to the issue this PR addresses.
I'd like to merge, but need someone to validate that the fix works as I, personally, don't have access to a windows machine. Trying it with python 2.7 and 3.6 and listing the content of the files from master and this branch would be great! TIA
@mathom @pgpgpg Neither do I have access to a Windows machine, so can you check the updates, please? It seemed a problem with json files.
I think I have the same problem (building on Windows and deploying to AWS). My thin builds worked ok but the fat build using slim_handler=true did not. I just debugged to this point and found this post. I tried the solution above and it did not work for me.
I think I have the same problem (building on Windows and deploying to AWS). My thin builds worked ok but the fat build using slim_handler=true did not. I just debugged to this point and found this post. I tried the solution above and it did not work for me.
@drummonds Did you use zappa from my fork? clone my repo and do pip install path/to/repo and post the result of tarball
@drummonds Did you use zappa from my fork? clone my repo and do
pip install path/to/repoand post the result of tarball
Ok @aldokkani I need to step up a level - I just tried out your fix for this by copying into my hacked and debugging .virtualenv. It has taken me a couple of days to understand my problem and get me this far. I will now try properly. (It looks as though your code base is about six months behind the current master)
(It looks as though your code base is about six months behind the current master)
@drummonds I have rebased my fork, thanks.. waiting for the result.
There are some problems with getting the code to install on a Windows machine which I am starting to fix. This affects both yours and my code. I am going to work through them and fix it. I will try and edit this once it is working.
