RJModules icon indicating copy to clipboard operation
RJModules copied to clipboard

Fails to compile

Open asbaklm opened this issue 7 years ago • 7 comments

Hi there, thanks for these great modules. Current version fails to compile with the following error in Sidechain.cpp:

src/Sidechain.cpp: In member function ‘virtual void Sidechain::step()’: src/Sidechain.cpp:50:72: error: expected ‘)’ before numeric constant if(inputs[TRIGGER_INPUT].value > 0 || inputs[TRIGGER_INPUT].value 0){ ^ ../../compile.mk:53: recipe for target 'build/src/Sidechain.cpp.o' failed

asbaklm avatar Nov 28 '17 07:11 asbaklm

Looks like you're missing an operator before that last zero. An == sign maybe ?

davephillips avatar Nov 28 '17 11:11 davephillips

Sorry, I forgot to commit the bugfix. Pushed now!

Are you compiling on OSX/Linux/Windows? I need somebody who has Windows to help me make a build so I can do a release.

I also need some help designing cross-architecture maintainable code..

Miserlou avatar Nov 28 '17 15:11 Miserlou

I can help with a windows and/or mac build. Let me know.

jeremywen avatar Nov 28 '17 20:11 jeremywen

I have a Mac, so I need help with the Linux and Windows builds. I can probably use Docker for the Linux builds no problem, but has anybody tried using MinGW for building Windows builds?

Miserlou avatar Nov 28 '17 21:11 Miserlou

ring me on irc. debian on my laptop and windows 7 on my desktop.

phdsg avatar Nov 28 '17 21:11 phdsg

here's a proactive build: zip contains both .so and .dll.

RJModules-dev-win_lin.zip

phdsg avatar Nov 28 '17 22:11 phdsg

Thanks for the fix, I was compiling on Linux, compiles perfectly now. Thanks again, these modules look really nice.

asbaklm avatar Nov 29 '17 06:11 asbaklm