Michaela Robosova
Michaela Robosova
Couple of last notes from me @AllanOXDi, then I think we'll be ready for merge :)
I also manually tested the new resource card now and one thing came out it'd be good to address now and that is when I click the bookmark or info...
@AllanOXDi following-up on ^ I assume that `@click.stop` like you did here should do? https://github.com/learningequality/studio/pull/4480/commits/07a4131b3e242e2f8b35b4e574028d024358dc96#diff-a836f27f6ada2a7aa18ebaa5c94993244781588b3be7930037c89960c3d556bdR34-R35
> This is something that I already tried. @AllanOXDi would you say a bit more so I can understand what was troubling - best would be to share the concrete...
Thank you @AllanOXDi, I will look at it later today if I can spot something :) As `KCard` went through many updates since, it's possible something works differently compared to...
@AllanOXDi I looked into the issue with `@click.stop` not working and it's a regression I caused in `KCard` a couple of weeks ago. Fixed it here https://github.com/learningequality/kolibri-design-system/pull/774. Would you try...
@AllanOXDi I will give it a final look after QA related code is cleaned up
@AllanOXDi I'm sorry there's still some changes that shouldn't be here before merge. Would you always preview "Files changed" tab? I'm not particularly concerned about added/removed empty lines etc. but...
I don't think you pushed it then @AllanOXDi or perhaps internet connection troubles? See here https://github.com/learningequality/kolibri/pull/12418/files . It's really best to preview "Files changed" because than you...
Thanks @AllanOXDi