Michaela Robosova
Michaela Robosova
Related https://github.com/learningequality/kolibri-design-system/issues/697
Hi @muditchoudhary, thanks a lot! I think as first step, we will QA in Kolibri. Would you be able to open a Kolibri PR for testing that would reference the...
Thanks a lot @muditchoudhary! Just answered. Seems we're close, great work.
Thanks @muditchoudhary! Yes, `develop`, that's right. Would you mind also updating https://github.com/learningequality/kolibri/pull/12325 to point to this latest work, so that we can QA again in Kolibri? There were lots of...
> Would you mind also updating https://github.com/learningequality/kolibri/pull/12325 to point to this latest work, so that we can QA again in Kolibri? There were lots of changes, so it'd be great...
Great @muditchoudhary, thanks a lot too! Joy on my side. I will have a look at the latest changes, hopefully some time this week, and also ask my colleagues for...
@muditchoudhary All new code looks well to me, and testing here on KDS passes. We will wait for the final QA confirmation from https://github.com/learningequality/kolibri/pull/12325 and then I will merge. FYI...
@muditchoudhary I also added the example with grids to docs, since I don't think people would figure out this is actually supported :)!
QA in https://github.com/learningequality/kolibri/pull/12325 passed so merging. Great work @muditchoudhary.
Even though I think some comments could help, nothing blocking from me regarding the documentation - will leave the decisions on you and @AlexVelezLl. Overall it reads very well :)...