Michaela Robosova

Results 933 comments of Michaela Robosova

I wonder if this is related to the problem with the devserver. `yarn generate` gives me this error ![Screenshot from 2024-06-05 11-50-49](https://github.com/learningequality/kolibri-design-system/assets/13509191/a0b082c4-1ae6-40b6-ae36-d537b251165f)

Good news is that I could successfully run - yarn lint - yarn lint-fix - yarn lint-watch - yarn pregenerate - yarn dev-only - yarn precompile-svgs - yarn precompile-custom-svgs -...

@bjester Upgrading yarn to v1.22.22 as discussed helped me with `yarn dev` that works now. I still see problem with `yarn generate`. But we can have a look whether that's...

I will unassign myself from the asigned reviewer role for now since everything is reviewed at this point. So that I don't block another round of review as I will...

For the current interface see "Context menu" section in the [KDropdownMenu](https://design-system.learningequality.org/kdropdownmenu/) and [`isContextMenu` prop](https://design-system.learningequality.org/kdropdownmenu/#prop:isContextMenu). The main advantages for this API are - Ease of use - Compatibility with the existing...

Thank you @radinamatic and @AllanOXDi. Regarding responsiveness - that's something that a grid will control, so yes, it is to be implemented and tested later on. Regarding buttons in the...

[required] `title` slot is to be an alternative to the `title` prop, however now the slot renders in addition to the `title` slot and is not showing in a correct...

[required] One important area to address here is to check the resulting UI against [the "Updated Cards Specs Metadata" designs](https://www.figma.com/design/1tQQ0Sw1yDjzO66hyjLVPM/Kolibri-UX-Fixes?node-id=1868-55352) and make sure that all the logic and styles that...

@AllanOXDi There are some acceptance criteria from the issues this PR is meant to close that appear not yet be implemented or have unclear status. Could you please read through...

@AllanOXDi I think I've finished the first round. At this point, I focused rather on higher-level issues. I will review one more time after this feedback as well as feedback...