Minecraft-CameraOverhaul icon indicating copy to clipboard operation
Minecraft-CameraOverhaul copied to clipboard

Port to Forge

Open Mirsario opened this issue 4 years ago • 7 comments

Plenty of people want this. And, if I remember correctly, there's a rather simple EntityViewRenderEvent.CameraSetup in forge, so this shouldn't be too difficult.

Mirsario avatar Dec 19 '20 14:12 Mirsario

That's great news! Happy to test out any prototype in the future

pa1nki113r avatar Jan 01 '21 20:01 pa1nki113r

It got done! https://www.curseforge.com/minecraft/mc-mods/camera-overhaul-forge

Neko2n avatar Feb 04 '21 17:02 Neko2n

It was done by me, but for some reason github wont let me PR it to this repo :sob:. Do you want me to add you to the curse project or to my fork of this repo? @Mirsario

CorgiTaco avatar Feb 04 '21 17:02 CorgiTaco

It was done by me, but for some reason github wont let me PR it to this repo 😭.

You probably can't PR it because, for one, you started a branch without basing it on any other, so the history is from scratch, and, for second, the target branch would be one with "fabric" in its name. Though the latter can be fixed by me after a PR is made.

Do you want me to add you to the curse project or to my fork of this repo? @Mirsario

Add me to the fork and I'll fix its history for a PR to work. As for curse, I personally would heavily prefer for the original one to have forge releases together with fabric ones, if you don't mind. Otherwise, technically, the license means that you can do anything, and I'll respect it.

Mirsario avatar Feb 05 '21 00:02 Mirsario

Alright I sent you an invite, feel free to fix the history. Ill delete the curse page aswell once you've got it uploaded on the fabric page. BUT TBH it's much easier for users to have separate pages for this mod IMO. Bc if you have fabric releases, people will complain andddd if the fabric category is there, forge users will just skip over it.

CorgiTaco avatar Feb 05 '21 01:02 CorgiTaco

That's amazing news! I was hoping to use that mod on my modpack. Also is there a 1.15.2 version in the pipes?

Vaalley avatar Feb 11 '21 16:02 Vaalley

I recommend adding [FORGE & FABRIC] in the mod title so people could know

lartts avatar Feb 14 '21 09:02 lartts