Mirror icon indicating copy to clipboard operation
Mirror copied to clipboard

feat: NetworkTransformReliable to allow partial support of runtime changing sendIntervalMultiplier

Open JesusLuvsYooh opened this issue 1 year ago • 3 comments

As discussed here: https://discord.com/channels/343440455738064897/1270795122279186484/1271231586519486485

Opens up NTR for possible features such as network LOD/IM. NTU already supports this. Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

JesusLuvsYooh avatar Aug 08 '24 22:08 JesusLuvsYooh

Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

We can't merge this if it accidentally breaks people's projects

miwarnec avatar Aug 09 '24 07:08 miwarnec

Desynchronisation of position can happen if both sides have miss-matched values, but this PR at least is a step towards the right direction of the feature.

We can't merge this if it accidentally breaks people's projects

It does not break projects, it won't do anything to previous or current users that do not intentionally try to change sendIntervalMultiplier during runtime. Currently in master, if someone does change sendIntervalMultiplier during runtime, the entire movement just stops, and never works again. (the counter variable has gone too high, and needs to be == to reset, we're just checking if counter is equal or higher to cover this >= ) With this PR, movement works again if changed during runtime, how well it works is spotty due to the nature of delta feature.

JesusLuvsYooh avatar Aug 09 '24 08:08 JesusLuvsYooh

It does not break projects, it won't do anything to previous or current users that do not intentionally try to change sendIntervalMultiplier during runtime.

I agree to this too. This change should logically prevent any accidental runtime changes to sendIntervalMultiplier from causing issues, without affecting existing projects. I haven't tested it myself, but it looks like it should only impact situations where someone intentionally modifies sendIntervalMultiplier during runtime.

How well it works might still be a bit hit or miss due to the delta feature idk :3 I mean the tests say its okay >.<

realQuartzi avatar Aug 09 '24 09:08 realQuartzi