Mirror icon indicating copy to clipboard operation
Mirror copied to clipboard

perf: batcher no-dict lookup for (Un)Reliable

Open imerr opened this issue 2 years ago • 1 comments

Dict lookup uses 6% in an il2cpp build for 121 nts, this ugly patch brings that down to 0.x%

I don't like this from a code perspective, so lets talk if there's a better way

Do people actually use channel ids that are big? We could do an array lookup instead with the channelId as index if they dont Or looping over a list to find the channel by id should be faster than using a Dict for 2 (or a handful) of values Allowing more than the 2 default channels might be useful for some people, so I wouldnt advocate removing them outright

Bleh.

imerr avatar Feb 14 '23 21:02 imerr

Profiler screenshots: image vs image

imerr avatar Feb 14 '23 21:02 imerr