Mirror
Mirror copied to clipboard
MirrorNetworking
Room Manager allow join in progress
Video demonstration. https://www.youtube.com/watch?v=gTp6rODMnXU Shows Rooms working like they previously worked if AllowJoinGameInProgress is false then shows Join in progress working when set to true
- Add AllowJoinGameInProgress, default to false
- Add OnRoomServerPlayerJoinedInProgress virtual method
- Recalculate room indices in the manager rather than the room player so it calculates accurately if a player joins in progress.
This has been asked before in the discord and every time the response is to make your own NetworkManager since the RoomManager wasn't designed to allow late joining, so they probably won't merge this.
This has been asked before in the discord and every time the response is to make your own NetworkManager since the RoomManager wasn't designed to allow late joining, so they probably won't merge this.
I'm not sure what you mean? Just because something wasn't originally made without a feature, doesn't mean it can't be added later.
from what I've seen in the discord this hasn't been done because its low priority, and was seen as too hard to figure out for the payoff, which considering this is like my 4th attempt to fix this, I don't disagree with 😅
I don't speak for the mirror devs directly so it's possible that they could merge it, but I recall one of them saying once "If it was a simple fix, it would have been implemented a while ago". I'm just saying what I've seen.
I was testing it out on my game and it works well! I would suggest to add a function to create the game player if its a late join.
Since there hasn't been any action on this pr in over a month, it might be best to create a repo with the modified lobby script and share it in the mirror discord cause this really helped out with my game.
sorry everyone, took me this long to even look at it.
super useful. will try to get this rebased and merged asap
EDIT: veto from MrG
sorry everyone, took me this long to even look at it.
super useful. will try to get this rebased and merged asap
EDIT: veto from MrG
Why was this veto'd its surely an obvious improvement?
I've played a multiplayer game that used network room manager and couldn't join games in progress it caused major issues for the game.
@MrGadget1024 according to @pdaulby in discord, there used to be issues with this but not anymore. could you take another look? otherwise we can go ahead and merge this