Mirror icon indicating copy to clipboard operation
Mirror copied to clipboard

Calling StopClient from OnStopClient (with other function in between) causes StackOverflowException

Open James-Frowen opened this issue 5 years ago • 5 comments

Describe the bug Calling StopClient from OnStopClient (with other function in between) causes StackOverflowException image

Expected behavior StopClient should not call OnStopClient if it has already been called

James-Frowen avatar Jul 09 '20 20:07 James-Frowen

Just need IsClientStopping and IsServerStopping private bools that are set true and checked in OnStopClient and OnStopServer respectively.

MrGadget1024 avatar Oct 02 '20 11:10 MrGadget1024

reopened. fix had to be reverted because of this bug: https://github.com/vis2k/Mirror/issues/2842

miwarnec avatar Jul 20 '21 03:07 miwarnec

reopened. fix had to be reverted because of this bug: #2842

Is this fixed now that #2842 has been closed as fixed?

MrGadget1024 avatar Aug 01 '21 03:08 MrGadget1024

This is still a bug.

MrGadget1024 avatar Sep 29 '21 14:09 MrGadget1024

Can't a similar solution work, just have separate bools for server and client, not using the same?

ninjakickja avatar Dec 13 '21 01:12 ninjakickja