cri-dockerd icon indicating copy to clipboard operation
cri-dockerd copied to clipboard

cri-dockerd does not set Resources to ContainerStatus

Open esotsal opened this issue 1 year ago • 1 comments

cri-dockerd does not set Resources to ContainerStatus code

For comparison containerd sets it code

This results to K8s failure to throttle pod so that it follows resized CPU limit on minikube when cri-dockerd is used.

InPlacePodVerticalScaling in K8s is soon going to reach Beta and luck of such support from cri-dockerd means that end users will face this limitation as described https://github.com/kubernetes/kubernetes/issues/118371 in minikube if cri-dockerd is used.

esotsal avatar Oct 17 '24 16:10 esotsal

As far as I know, having Docker support was not a blocker for KEP-1287

As of Kubernetes v1.20, the CRI has included support for in-place resizing of containers via the UpdateContainerResources API, which is implemented by both containerd and CRI-O

So I am not sure that the feature will ever be implemented for Docker?

  • #185

afbjorklund avatar Dec 19 '24 17:12 afbjorklund