cri-dockerd icon indicating copy to clipboard operation
cri-dockerd copied to clipboard

[Question] Support for new functionality after dockershim

Open WMP opened this issue 2 years ago • 2 comments

In K8S 1.25 cgroupv2 ( https://github.com/kubernetes/enhancements/issues/2254 ) is enabled, in containerD 1.7 ( https://github.com/containerd/containerd/blob/main/docs/NRI.md ) there is support for Node Resource Interface, and k8s 1.27 adds support for memory QoS ( https://github.com/kubernetes/enhancements/issues/2570 ) . Using cri-dockerd will it be possible to use these functionalities?

WMP avatar Apr 26 '23 13:04 WMP

Cgroups v2 is supported since Docker 20.10, and is default in eg Ubuntu 22.04

https://www.docker.com/blog/introducing-docker-engine-20-10/


But I believe that the new field (LinuxContainerResources) was not implemented for docker, only containerd and cri-o?

https://kubernetes.io/blog/2021/11/26/qos-memory-resources/

There is supposed to be a Config.Linux.Resources, now with a new key "Unified".

https://github.com/moby/moby/blob/master/api/types/container/hostconfig.go

afbjorklund avatar Apr 26 '23 16:04 afbjorklund

I don't think there are any plans to implement the NRI adaptation for Docker, but I could be mistaken ?

The goal is to enable NRI support in the most commonly used OCI runtimes, containerd and CRI-O.

afbjorklund avatar May 05 '23 13:05 afbjorklund