MinusKube

Results 47 comments of MinusKube

Okay I'm working on improving the code of this PR, but I just learned about the `LineBuilder` class in the engine, and I'm wondering: why would someone use the polyline...

> Visually an obvious improvement. Code-wise it looks ok. Fine to merge to me. > > I mainly dislike some variable naming like segment directions being called `segment`, or `tangent`...

> @MinusKube Yeah, `segment_dir` should be clear enough. Regarding `tangent`: you could have that helper function changed to something like `compute_polyline_miter_joint_left_offset_clamped(p_prev_segment_dir, p_segment_dir)` to make it super clear. This function is...

You can also use `iter.allowOverride(false)` so the iterator will skip non-empty slots