anything-llm icon indicating copy to clipboard operation
anything-llm copied to clipboard
Published 2 weeks ago • verified publisher icon Mintplex-Labs

[FEAT] Login by social providers (Google for now)

Open giovaborgogno opened this issue 1 year ago • 11 comments

Pull Request Type

  • [x] ✨ feat
  • [ ] 🐛 fix
  • [ ] ♻️ refactor
  • [ ] 💄 style
  • [ ] 🔨 chore
  • [ ] 📝 docs

Relevant Issues

resolves #1193

What is in this change?

This PR introduces the ability for users to log in using their Google accounts, providing the flexibility for administrators to enable or disable this feature. Additionally, administrators can restrict login access to a specific organization's domain. The implementation is designed with a modular structure, allowing for easy integration of additional authentication providers in the future.

Additional Information

image

After enable login by google:

image

Developer Validations

  • [x] I ran yarn lint from the root of the repo & committed changes
  • [x] Relevant documentation has been updated
  • [x] I have tested my code functionality
  • [x] Docker build succeeds locally

giovaborgogno avatar May 09 '24 23:05 giovaborgogno

Damn, this is awesome!

timothycarambat avatar May 10 '24 00:05 timothycarambat

Hey @timothycarambat, are there any intentions to work on this PR? It looks really good

emilioh93 avatar May 15 '24 13:05 emilioh93

@emilioh93 There is nothing wrong with the PR, it just needs to be reviewed and we need documentation to set it up because I dont want to be responsible for 400 github issues from people setting it up incorrectly and saying it is broken!

From what i already tested, it works great & will be merged

timothycarambat avatar May 15 '24 20:05 timothycarambat

@emilioh93 There is nothing wrong with the PR, it just needs to be reviewed and we need documentation to set it up because I dont want to be responsible for 400 github issues from people setting it up incorrectly and saying it is broken!

From what i already tested, it works great & will be merged

@timothycarambat, thanks for your reply. I agree that documentation is crucial to avoid configuration issues. I appreciate your time and effort in reviewing this PR.

emilioh93 avatar May 15 '24 21:05 emilioh93

What are the places where should one put the documentation?

matejc avatar Jun 05 '24 08:06 matejc

@matejc Our docs repo https://github.com/Mintplex-Labs/anythingllm-docs

timothycarambat avatar Jun 06 '24 17:06 timothycarambat

Oh I am excited about this feature, thanks!

gh-gourneau avatar Jun 21 '24 17:06 gh-gourneau

It's great! It simply opens the path for other login methods such as LDAP. Ideal for self hosted in a small company.

bmkor avatar Jul 02 '24 00:07 bmkor

this would be a fantastic feature! Waiting for this to get merged.

jlmatus avatar Jul 22 '24 19:07 jlmatus