Alexander Batischev comments

Results 720 comments of


                                            Alexander Batischev

gettext-rs is unsound as the `gettext` family is MT-Safe env

Thanks for reporting this! Unfortunately, FFI crates aren't the place to fix this; the underlying library calls (libc's `getenv` and `setenv`) give us no tools to avoid this unsafety, and...

tar is using non standard flags (patch)

Thanks! Windows also has problems with `tar`, so we'll ship an unpacked tarball instead. I hope to push it out next week.

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

Hi! Can you build GNU gettext itself in this environment, without using the crate? (I'm trying to understand if the problem is with GNU gettext itself, or just with our...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

Sounds plausible. I admit I never cross-compiled anything in my life, so I can't really give any advice here :) If you unpack the tarball that we ship as part...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

> Maybe that simply not building the gettext examples (including hello.c) would work out better. Oh :sweat_smile: Indeed, we only need libraries, so if disabling the examples helps, then it's...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

> Is this due to the choice of dynamically building the library using ./configure rather than ./autogen.sh? Most probably. Unfortunately, ./autogen.sh requires autotools and downloads files from the Internet, so...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

Relevant docs: https://git.savannah.gnu.org/gitweb/?p=gettext.git;a=blob;f=INSTALL.windows;h=72efd29f269ef0b83d777d873eb744c589c0cde9;hb=eb83efc3b58d690d444da0b82c3ecf36a54f28ac

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

The automated build process requires a certain *minimum* version of automake, and works fine with newer ones (like 1.16.3 from Debian testing). You should really bring this upstream; I'm not...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

> Most libraries don't need to have a global heap context shared between the process-wide users of the library like gettext does. Okay, you convinced me! Making `gettext-system` opt-out will...

"undefined reference to `libtextstyle_isatty'" linker error with trying to cross-compile "gettext-sys" for Windows using MinGW64

Ah, I see — I got confused by all the other problems you discovered :) Did you get a chance to try suggestions from my [first](https://github.com/Koka/gettext-rs/issues/76#issuecomment-894202796) and [second](https://github.com/Koka/gettext-rs/issues/76#issuecomment-894364236) comments? I...