ros2_data_collection
ros2_data_collection copied to clipboard
Rename custom_params to custom_keys
This task consists in renaming:
custom_str_param_listtocustom_key_str_listnode paramtercustom_str_paramstocustom_keys_strnode paramter- All variables with
custom_paramstocustom_key
The documentation of the parameters are located here https://minipada.github.io/ros2_data_collection/dc/measurements.html#node-parameters
The reason to do so is that we are not adding custom parameters but custom keys to the JSON.
To do it, I would suggest to do a Ctrl-F an do search and replace.
They are located in: https://github.com/Minipada/ros2_data_collection/blob/humble/dc_core/include/dc_core/measurement.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement_server.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/src/measurement_server.cpp
Then we should also rename them in the documentation. To run the documentation locally and see your changes, check the FAQ https://minipada.github.io/ros2_data_collection/dc/contributing.html#docs
Hey @Minipada , can i take this? please let me know if i need to follow any guidelines for this.
Thanks
Hi @Akashutreja , thanks for offering your support, I'll gladly take it. I edited the description in the task and feel free to ping me if you need more help!
Hey @Minipada ,
I am done with code but while pushing code I am getting below permission error, can you please check this?
remote: Permission to Minipada/ros2_data_collection.git denied to Akashutreja.
Great! Please fork, push on your fork and do a PR