ros2_data_collection icon indicating copy to clipboard operation
ros2_data_collection copied to clipboard

Rename custom_params to custom_keys

Open Minipada opened this issue 2 years ago • 4 comments

This task consists in renaming:

  1. custom_str_param_list to custom_key_str_list node paramter
  2. custom_str_params to custom_keys_str node paramter
  3. All variables with custom_params to custom_key

The documentation of the parameters are located here https://minipada.github.io/ros2_data_collection/dc/measurements.html#node-parameters

The reason to do so is that we are not adding custom parameters but custom keys to the JSON.

To do it, I would suggest to do a Ctrl-F an do search and replace.

They are located in: https://github.com/Minipada/ros2_data_collection/blob/humble/dc_core/include/dc_core/measurement.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/include/dc_measurements/measurement_server.hpp https://github.com/Minipada/ros2_data_collection/blob/humble/dc_measurements/src/measurement_server.cpp

Then we should also rename them in the documentation. To run the documentation locally and see your changes, check the FAQ https://minipada.github.io/ros2_data_collection/dc/contributing.html#docs

Minipada avatar May 22 '23 07:05 Minipada

Hey @Minipada , can i take this? please let me know if i need to follow any guidelines for this.

Thanks

Akashutreja avatar May 22 '23 19:05 Akashutreja

Hi @Akashutreja , thanks for offering your support, I'll gladly take it. I edited the description in the task and feel free to ping me if you need more help!

Minipada avatar May 22 '23 19:05 Minipada

Hey @Minipada , I am done with code but while pushing code I am getting below permission error, can you please check this? remote: Permission to Minipada/ros2_data_collection.git denied to Akashutreja.

Akashutreja avatar May 23 '23 19:05 Akashutreja

Great! Please fork, push on your fork and do a PR

Minipada avatar May 23 '23 19:05 Minipada