minicraft-plus-revived icon indicating copy to clipboard operation
minicraft-plus-revived copied to clipboard

Published 20 hours ago • verified publisher icon MinicraftPlus

Move torch variations into tile data

Open BenCheung0422 opened this issue 1 year ago • 5 comments

Using duplications in the main method is not a great idea, so this changes torch tile variations into handling the tile data instead. ~~When #437 is merged, TileModel can be used to merge TorchItem into a general TileItem instance.~~(outdated) TorchItem is merged to TileItem with the advanced feature from TileModel. Tile sprite connection fields are converted to methods to suit the changes.

BenCheung0422 avatar Aug 09 '23 15:08 BenCheung0422

Please fix conflicts.

Litorom avatar Feb 12 '24 17:02 Litorom

The code to load torch is not removed, so it is not affected.

BenCheung0422 avatar Feb 13 '24 09:02 BenCheung0422

Conflicts resolved.

BenCheung0422 avatar Feb 13 '24 10:02 BenCheung0422

The code to load torch is not removed, so it is not affected.

Yes, but then it tries to load the tourch with a the old name on new saves. That will cause an error.

Makkkkus avatar Feb 13 '24 14:02 Makkkkus

Yes. And I fixed that error in the latest commit recently.

BenCheung0422 avatar Feb 13 '24 14:02 BenCheung0422