minicraft-plus-revived
minicraft-plus-revived copied to clipboard
MinicraftPlus
Adds a Debug Panel
This adds a debug panel and removes all in-world debugging key bindings. This could make the key bindings cleaner and neat. Instead, a list entry menu (triggered by F4) is used and searching is available. (No localization) This would be a way to organize all the debugging functions and features without a lot of (confusing or messy) key bindings.
No new debug panel is needed. The arguments I presented in #502 still apply. This is bloat, and I would prefer going back to the way it was before #454 (although not all changes are bad in that pull-request).
However, I think there might be too many key bindings and that might make confusion. And I prefer reducing unnecessary key bindings as not all debugging keys are always used and sometimes they bind to different modifiers .
It can still be a problem as sometimes looking-up for key bindings is still required if the key bindings are forgotten or not yet known.
And a in-game instant lookup. F3 only triggers the debugging information panel, but this F4 triggers an action panel.
There are 23 associated debugging key bindings, if every time using the bindings requires lookup, using built-in interface with only 1 key would be better than opening up the wiki page on browser and find line by line the key bindings required. This compresses 23 key bindings into 1 key. Sometimes, if it is required to add debugging functions, new key bindings are always needed, but in the panel, it is not a hard requirement.
I'll reopen this on the condition that you readd the --debug launch argument.
I have re-added Game#debug and --debug flag. The corresponding codes that was relying on that field have also recovered. I am not sure if the detailed debugging flags --debug-* should be enabled only when --debug is also enabled.
There could be a function to area set tiles with using menus (inputs) and some more useful functions can be used for making maps?
When making maps, special actions to changes tiles and entities are required. Testing some features may also require large range tiles.
Customizing worlds in creative mode. Although there are currently no trends in making maps and publishing maps because there is lack of this kind of functionality, testing some features is still requiring an environmental setup and that might require major change to the testing world. Having this kind of debugging or creative mode exclusive functions could reduce the work required and make convenience. Some of this kind of functions I can think of are tile setting, region filling, entity summoning, potion effect modifying, etc.
Add a debug function entry in the panel and use menus to do the actions.
It also adds another function to creative mode, like Minecraft's fill command.
There are several functions I want to add for the panel (might be enabled in creative mode?):
- regional tile filling - implementation with using a sub-menu of tile list or input entry for tile selection and another 2 sets of input entries specifying the region.
- tile setting - specifying a tile with positions and modifying the tile data.
- entity killing - killing entities by conditions.
- item giving - giving an item with using an input entry and may allow modifying item data.
- status effect modifying - adding or removing player's status effects (potion effects).
- inventory clearing - clearing the whole inventory.
- day locking or time locking - locking the daytime and day-night cycle.
- entity summoning - summoning a or a number of specific entity(s) without a spawner (softly or forcedly).
Nothing should be enabled when you aren't in debug mode. It shouldn't matter if you are playing on creative or survival.
Right, since they are debug functions. Then what about the functions mentioned to be added?
However, I am not sure how should I do for tile selection. Tile (or entity, etc.) list menu could be intuitive, but an input entry could be convenient without scrolling.
We might change some of them into string commands if we need to. Also, the implementations of the commands proposed previously have been done.
I have reviewed the PR, but I don't approve of the changes as explained in Discord.
