MiniMappingViewer icon indicating copy to clipboard operation
MiniMappingViewer copied to clipboard

Add 1.17 mappings

Open TobiasDeBruijn opened this issue 4 years ago • 5 comments

Hey there,

When opening the Mojang->Spigot mappings for 1.17, Error while loading spigot mappings: Version not found is thrown.

However content is displayed, but I don't know how up-to-date this is, or if it is correct. The 'Spigot Name' field is empty.

TobiasDeBruijn avatar Jun 11 '21 09:06 TobiasDeBruijn

Note also that some classes, e.g net.minecraft.network.protocol.game.PacketPlayOutPosition don't show up in search results.

TobiasDeBruijn avatar Jun 11 '21 13:06 TobiasDeBruijn

there is way more stuff to do, as spigot partly uses mojang mappings now.

and since paper will be moving to mojang mappings, quite frankly, am not sure if updating it is worth it, everbody should code against mojang mappings.

ill still leave this open just in case

MiniDigger avatar Jun 11 '21 14:06 MiniDigger

I suppose it might be best to leave the spigot names empty, since as you mentioned people should now be using mojang mappings.

However, I do think it's important to update the mappings, even just to get the mappings between mojang (sensible) names and their obfuscated counterparts, it's darn useful information for people (like me) using reflection :D

TobiasDeBruijn avatar Jun 11 '21 14:06 TobiasDeBruijn

I'm not sure on how to make a pull request for glist's aka(builddata.json) also this might not be correct I think it is though

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-cl.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

https://hub.spigotmc.org/stash/projects/SPIGOT/repos/builddata/raw/mappings/bukkit-1.17-members.csrg?at=b6171b29323150f031a1a22e0f42c18809878ef1

andrew121410 avatar Jun 13 '21 04:06 andrew121410

changing the gist is not enough, the code itself needs to be fixed. 1.16.5 is already broken

MiniDigger avatar Jun 19 '21 14:06 MiniDigger