amazon-alexa-php icon indicating copy to clipboard operation
amazon-alexa-php copied to clipboard

Published 20 hours ago • verified publisher icon MiniCodeMonkey

Instances of $applicationId vs. $applicationid

Open torreytooj opened this issue 8 years ago • 2 comments

Throughout seemingly all of this library, the Amazon App ID is defined in either the variable or a property called "applicationId". I noticed some areas where it was called "applicationid" instead, as well a few instances where it was missing as an argument:

IntentRequest.php Line 9/10 - Missing $applicationId as 2nd argument in __construct function.

Request.php Line 94 - Missing $this->applicationId as 2nd argument in new Request class creation.

These were reported in my Drupal 8 error logs while I build an Alexa integration app. I am new to this library though, so if I am incorrectly reporting this as an issue for some reason, please let me know so I can correct this.

torreytooj avatar Jun 19 '16 19:06 torreytooj

Also seeing the lowercase version defined in line 20 of /Request/Request.php

deltafactory avatar Nov 19 '16 03:11 deltafactory

@Izion has fixed quite a few of these in the following commit https://github.com/Izion/amazon-alexa-php/commit/14ec0df829d20849e3e203b6808b2f2199d1cc97

danstreeter avatar Dec 27 '16 15:12 danstreeter