amazon-alexa-php icon indicating copy to clipboard operation
amazon-alexa-php copied to clipboard

Merge a fork?

Open jakubsuchy opened this issue 8 years ago • 3 comments

The fork by @kora88 currently has all the necessary validation tools, could it be merged here so users don't discover an incomplete toolkit via Composer?

jakubsuchy avatar Apr 02 '16 01:04 jakubsuchy

It would be great to merge that!

MiniCodeMonkey avatar Apr 15 '16 01:04 MiniCodeMonkey

Agreed - there are a lot of forked upstream fixes that fix some vital things. I'm using this library for a custom skill i'm working on - so might fork and merge all fixes in as one hit to get me going.

danstreeter avatar Dec 27 '16 15:12 danstreeter

Looking at the forks and history of each one, @froodley https://github.com/froodley/amazon-alexa-php/network has done a lot of work with code. Edit I see now that froodley has identified it is a breaking change from the initial repo and it will no longer work as a possible merge, but there are some good things to possibly add back in. I was trying to get slots working with an app and see that some of the code they added to the Intent class helps in getting some of the data from the request.

emerham avatar May 09 '17 15:05 emerham