Mingwei Samuel

icon indicating a website link https://github.com/MingweiSamuel

icon location Oakland, CA

Results 305 comments of Mingwei Samuel

`LatticeBimorphism` trait should be modified to support references instead of just owned values, to avoid unnecessary `clone()`ing

Related: should it be able to return an iterator of items instead of just one

refactor: generate schema code in `build.rs`

Maybe even splitting the generated code into a separate crate would be useful. To separate the compilation unit, and to repair our broken semantic versioning

refactor: generate schema code in `build.rs`

Make sure to handle https://github.com/MingweiSamuel/Riven/issues/91 tournament regions

refactor: generate schema code in `build.rs`

https://github.com/MingweiSamuel/Riven/commit/a673505b39ce29a339492f0469f65fa6de3e939c https://github.com/MingweiSamuel/Riven/commit/e6360170ecf4789dc7eb19433656ab707b4b08a5 changes need to be included

Log warning on windows

(I develop on windows 11 22631.5189 and have not had this error)