TeemoJS icon indicating copy to clipboard operation
TeemoJS copied to clipboard

Add Typescript Typings

Open MingweiSamuel opened this issue 5 years ago • 6 comments

TeemoJS is very javascript-ey, i.e. very untyped, but it would still be nice to provide typescript typings when possible.

https://gist.github.com/molenzwiebel/7bf64a4b79f609c4bae85f1db38ef08e

MingweiSamuel avatar Dec 28 '19 20:12 MingweiSamuel

Would like to see this. I'm exploring other options as a javascript Riot API library.

Querijn avatar Jan 13 '20 13:01 Querijn

Project is being rewritten in typescript now

MingweiSamuel avatar Jun 16 '20 16:06 MingweiSamuel

Version 3 (prerelease) now has full TypeScript typings https://www.npmjs.com/package/teemojs/v/3.0.0-rc.1 https://github.com/MingweiSamuel/TeemoJS/tree/master#readme

MingweiSamuel avatar Jul 09 '20 06:07 MingweiSamuel

@MingweiSamuel thanks for your update, is the version 3 working with datadragon? and if yes, how should we proceed?

itryp avatar Jun 09 '21 13:06 itryp

@itryp V3 doesn't have a ddragon config right now, but I can add one soon

MingweiSamuel avatar Jun 09 '21 17:06 MingweiSamuel

@MingweiSamuel just following up with the ddragon config. Just wondering if it is working with teemoJs at the moment?

jbryant4 avatar Aug 08 '21 07:08 jbryant4