Bogdan Mingela

Results 52 comments of Bogdan Mingela

Thanks for the exhaustive overview @0x009922. Solution 3 seems to be the most convenient from the perspective of how serialized objects look. What about replacing `Option` with `JsonNode` (`JsonObject`)? so...

> I don't see how it's going to solve the same ambiguity when someones needs to set a `null` payload Here we should just decide about a nullable type to...

@mversic I couldn't see how your examples are relevant though, by the current schema the values expected are: * `"payload": "{\"account\":\"ed0120CE7FA46C9DCE7EA4B125E2E36BDB63EA33073E7590AC92816AE1E861B7048B03@wonderland\"}"` * `"payload": "[\"ed0120CE7FA46C9DCE7EA4B125E2E36BDB63EA33073E7590AC92816AE1E861B7048B03@wonderland\"]"` and @arndey refers to `null` value...

I can understand the concept but there is no indication of how it should be treated by the client given we encounter both `Option` and `JsonString` possibly having the same...

In case `"value" : "vsmIjTvWstOuyjYwairbDnKggldFrDkhtyzcqfAttzeJjKcioW"` should be `"value" : "\"vsmIjTvWstOuyjYwairbDnKggldFrDkhtyzcqfAttzeJjKcioW\""` the genesis block should be explicitly denied by Iroha's validation imo. Though it'd be great to see more motivation not...

Let me comment on specific statements, - Agree on removal of `Register`, `Unregister` for assets. - As for the permission to limit ownership, for example in Iroha1 there are `can_transfer`...

> I think removing it should be out of this issue's scope because it requires a deeper ISI refactor. Alright, just make sure the further step is implemented within the...

Is it going to be reflected in the schema somehow? Would be great to see a proposal for that before merging the change.

yeah it seems trigger executions should rather be injected immediately after a related event is emitted

I guess it would be more transparent to create a specific transaction type for that (e.g. `TriggerExecution`). If events are contained in blocks it could be just an event type...