Extra-Golems icon indicating copy to clipboard operation
Extra-Golems copied to clipboard

Golems not being removed/deleted via datapacks

Open Wackywee opened this issue 1 year ago • 6 comments

Why can I only remove the quark charcoal golem via datapack? I put the other ones I want to remove in the same directory, and all of the following directories and it doesnt work. (Integration_Pack is the name of my datapack)

Integration_Pack\data\golems\golems\golem_stats Integration_Pack\data\golems\extragolems\golems\golems\golem_stats Integration_Pack\data\golems\extragolems\golems\golem_stats Integration_Pack\data\golems\extragolems\golem_stats Integration_Pack\data\golems\golem_stats Integration_Pack\data\extragolems\golem_stats Integration_Pack\data\extragolems\golems\golem_stats Integration_Pack\data\extragolems\golems\golems\golem_stats

I think the directory in your wiki is incorrect. Here is the composition of each .json: { "attributes": {} }

Thank you for any help.

Wackywee avatar Apr 16 '24 05:04 Wackywee

data/golems/golems is the correct directory for the charcoal golem in your version. For other golems added by quark, you need to use the data/quark/golems directory https://github.com/MinecraftModDevelopmentMods/Extra-Golems/tree/master-1.19.3/src/main/resources/golems_addon_quark/data/quark/golems

skyjay1 avatar Apr 16 '24 17:04 skyjay1

data/golems/golems is the correct directory for the charcoal golem in your version. For other golems added by quark, you need to use the data/quark/golems directory https://github.com/MinecraftModDevelopmentMods/Extra-Golems/tree/master-1.19.3/src/main/resources/golems_addon_quark/data/quark/golems

Sorry for the confusion, I was referring to the golems added by default, not quark. Such as the wool, deepslate, andesite, etc.

Wackywee avatar Apr 16 '24 19:04 Wackywee

Integration_Pack\data\golems\golems\golem_stats

This is the correct path for 1.16.5 through 1.19.3. If you are using 1.20.1, the wiki is not updated yet.

Please verify the data pack is loaded in-game with the /datapack list command

Also when you say it “doesn’t work” do you mean that the golem can still be built? Or do you mean it shows up in the guide book? The latter can be resolved by adding ”hidden”: true to the JSON

skyjay1 avatar Apr 16 '24 20:04 skyjay1

I'm using version 1.19.2, and my datapack is enabled. I have all features from it except the golems being disabled, as shown by this in the log that was printed following the /datapack list command [file/Integration_Pack (world)]

By doesn't work I mean the golems can still be built, which leads me to believe I would also be unable to change their attributes

Of additional note, your mentioned file path does work with my attempts to remove the charcoal golem.

Wackywee avatar Apr 16 '24 21:04 Wackywee

Is this going to be fixed?

Wackywee avatar Sep 29 '24 19:09 Wackywee

I'm unsure if 1.19.* is currently receiving support but sky is very busy with real life duties right now, as soon as either sky or someone else has a moment to poke this issue they will :)

KiriCattus avatar Sep 29 '24 19:09 KiriCattus