[1.20.2+] Path Finding doesn't respect Vanilla behavior

[konkitoman]

Minecraft Version: 1.20.2+

Forge Version: 48.0.0

Minecraft 1.20.1 47.4.6 is not affected, any version above is affected!

Steps to Reproduce:

1. Summon Ravager
2. Move in the north (-z) or west (-x) and stop after the block center but before the block edge.

Description of issue: The Ravager is getting stuck if you move north or west from it, he won't be able to attack you.

https://github.com/user-attachments/assets/fa5986ad-4241-48a9-b397-50ce7e246fdd

If the patch patches/minecraft/net/minecraft/world/entity/ai/navigation/PathNavigation.java.patch is not applied the issue stops happening in 1.21.1. All Forge versions over 47.4.6 has this problem, from my testing!

The issue title is alright?

[Jonathing]

Well, we're probably not going to fix this in 1.20.2, as we don't support it anymore. 1.20.4 is the next version after we still support, so we'd fix it for that and every supported version after.

This issue seems to imply that this issue started in 1.20.1-47.4.7. Is this true?

[konkitoman]

This issue seems to imply that this issue started in 1.20.1-47.4.7. Is this true?

~~1.20.1-47.4.7 works as expected!~~

Now tested

• 1.20.1 47.4.6 works as expected!
• I cannot find 47.4.7
• 1.20.1 47.4.8 works as expected!
• 1.20.1 47.4.10 works as expected!
• 1.20.2 48..0.0 has the issue!

[LexManos]

MC-94054 is an issue that is still open related to entities smaller then a full block. Not able to complete their navigation due to rounding errors. Which is what out patch fixes. Tho if it causes issues with large creaturs it may be another rounding error just in the opposite direction.

Im fine with just flat out reverting the patch as it doesnt seem like mojang cares about it and we more definitly dont want to introduce other issues. Tho if someone wants to take a look before i get back into town. My bet is that it's due to it now properly checking distance instead of truncating. Which would explain why it happens in one direction only.