ForgeFlower icon indicating copy to clipboard operation
ForgeFlower copied to clipboard

ForgeFlower Legacy; FG-2.2 Base

Open TheCurle opened this issue 2 years ago • 3 comments

This PR is the result of copying all the commits made on top of https://github.com/MinecraftForge/FernFlowerLegacy, converting those to patches, and applying them in the style of ForgeFlower.

All upstream patches are removed, and thus this should be considered a completely different product than the master branch; thus the branch this is PRed to uses a legacy- prefix.

This is Part 5 of the RetroGradle initiative.

Limitations

Being that this is forked from FernFlowerLegacy, it is limited to Java 9 features. Therefore, this version of ForgeFlower cannot decompile any J10+ features, such as records, try-with-resources, enhanced switch, or any other syntax sugar related code.

However, it does not need to; the Minecraft 1.11 (and below) code it is designed for does not use any of these.

TODO

  • [x] Test this version against the pre-existing RetroGradle toolchain for patch failures
  • [x] Figure out how we're going to do versioning (If this is pulled, it will clash with the existing commit versioning)
  • [x] Consider moving to a different artifact name (forgeflowerlegacy?)
  • [x] Consider moving to a different repository?

TheCurle avatar Mar 22 '23 03:03 TheCurle

I think for ease of management it makes sense to keep this in the same repo, but having a different artifact ID is imo the easiest way to distinguish the versions for consumers.

zml2008 avatar Mar 22 '23 03:03 zml2008

I have adjusted this so that it publishes under net.minecraftforge.forgeflowerlegacy with the versioning scheme of 0.{FG_VERSION}.{PATCH}.

The first build will thus be net.minecraftforge:forgeflowerlegacy:0.2.2.0.

With that, this is no longer a draft.

TheCurle avatar Mar 23 '23 01:03 TheCurle

Good that RetroGradle is moving along👍.

Codetoil avatar May 04 '23 20:05 Codetoil