MC-Eternal-1.12 icon indicating copy to clipboard operation
MC-Eternal-1.12 copied to clipboard

[BUG] Orbital laser drill does not mine all of the overworld ores

Open knedlikcz opened this issue 3 years ago • 5 comments

Describe the bug I don't know if you can call this a bug but I don't know how to use GitHub tags so sorry about that. So the orbital laser drill has disabled block destroying on planets and it generates ores based on an array list that it gets from config files, I am wondering if the array list has been altered or has been left as original. My question is, should it be changed?

Version of MC Eternal 1.4.4

To Reproduce Steps to reproduce the behavior:

  1. Go to C:\Users\UserName\curseforge\minecraft\Instances\MC Eternal\config\advRocketry
  2. Click on AdvancedRocketry.cfg
  3. press ctr + f and search " List of oredictionary names of ores allowed"

Expected behavior Should give all ores available in the overworld/earth (Dim 0)

knedlikcz avatar Jul 06 '21 21:07 knedlikcz

The Laser Drill pulls from a specific list in the config if Real Planet Mining is disabled, although i suppose this could be tweaked with some work.

    S:laserDrillOres <
        oreIron
        oreGold
        oreCopper
        oreTin
        oreRedstone
        oreDiamond
     >

anabsolutesloth avatar Jul 07 '21 23:07 anabsolutesloth

That's basically what I had in mind, I was not sure if the list was tweaked be the developer and if no. Is it possible to have it tweaked to simulate overworld mining?

knedlikcz avatar Jul 08 '21 08:07 knedlikcz

I was thinking something like this, if I left out something that should be there please notify me.

S:laserDrillOres < oreCoal oreIron oreGold oreLapis oreRedstone oreDiamond oreEmerald oreCopper oreTin oreSilver oreLead oreAluminum oreNickle orePlatinum oreQuartzBlack oreProsperity oremithril oreCinnabar oreCertusQuatz oreChargedCertusQuartz oreFossil oreRutile thaumcraft:ore_quartz techreborn:ore >

knedlikcz avatar Jul 08 '21 13:07 knedlikcz

Might whip up a PR later. Also, sidenote, you can't use ItemIDs for it, it specifically wants oredict entries.

anabsolutesloth avatar Jul 09 '21 06:07 anabsolutesloth

Well I am a bit confused then. In the config files it says both formats are acceptable image

knedlikcz avatar Jul 09 '21 14:07 knedlikcz