eei icon indicating copy to clipboard operation
eei copied to clipboard

Migrate to the latest rust for performance

Open pythonbrad opened this issue 1 year ago • 5 comments

Description

The current code follows rust 2018 edition. In migrating to the latest, we can have some performance improvement.

pythonbrad avatar Oct 08 '24 20:10 pythonbrad

@Mindful, what do you think to migrate to the rust latest to benefit of the performance improvement?

pythonbrad avatar Oct 08 '24 20:10 pythonbrad

Hey, so I think migrating to the latest Rust is a great idea - this was actually one of the things I was thinking I should do at some point anyway. I'm not sure how big the performance improvement will be, but any performance gain is great, and even if there wasn't a performance gain I think this would still be worth it.

Basically, I 100% support this, would be great.

Mindful avatar Oct 11 '24 04:10 Mindful

@Mindful, I checked the code again, and what I can do now is to update the dependencies.

pythonbrad avatar Oct 16 '24 10:10 pythonbrad

Is the the actual rust version difficult to update because it would require substantial changes to the code? If so, I can try and find some time to look into it.

Mindful avatar Oct 20 '24 23:10 Mindful

Is the the actual rust version difficult to update because it would require substantial changes to the code?

There are libraries like lazy_static who can be replaced by his equivalent standard library.

Others updates require to read the code to know how to optimize it.

For the moment, the change that I have in mind are minor.

pythonbrad avatar Oct 21 '24 05:10 pythonbrad