It would be nice if github releases had binaries for download

[jrwren]

I don't know how to set this up or if it can be automated with actions, but if someone can point me to docs and it is acceptable I'd love to send a PR to implement this.

I don't know rust and cargo and so I extracted a binary from the docker image. It works well, but it is less than ideal.

[tobikris]

I don't really know how to add this as a GitHub Action, but here is my workaround for now:

You can use the following snippet to compile the exporter with musl for x86_64.

The binary will be in $(pwd)/target/x86_64-unknown-linux-musl/release/prometheus_wireguard_exporter.

git clone https://github.com/MindFlavor/prometheus_wireguard_exporter.git
cd prometheus_wireguard_exporter
docker run --rm -it -v "$(pwd)":/home/rust/src ekidd/rust-musl-builder cargo build --release

[qdm12]

The Docker build now cross build for all available architectures, maybe we can use it and send the built binaries (statically linked with musl bundled) to the Github API.

Now the problem comes with OSX since all musl cross building tooling is for linux and not darwin, I'm not sure it would work.

Anyway, I think it's best to just use a Github Action for it (duplicating the CI work, but oh well), ~https://github.com/marketplace/actions/rust-release-binary looks promising.~ (only supports x86_64 ugh)

[qdm12]

Also note you could (trigger warning: sort of ugly) for Linux, as long as you have Docker, do:

docker pull mindflavor/prometheus_wireguard_exporter && \
  containerid="$(docker create mindflavor/prometheus_wireguard_exporter)" && \
  docker cp "$containerid:/usr/local/bin/prometheus_wireguard_exporter" /usr/local/bin/prometheus_wireguard_exporter && \
  docker rm "$containerid"

And have the static binary on your host 😉 I'll dig on how to upload them to Github releases using a similar approach, at least we will have Linux binaries. OSX will have to wait though.

EDIT: That should do together with those ugly docker commands running in the CI. I'll do it sometime soon.

[upstream-dmahlberg]

Is this ticket still alive? The PR could be merged without conflicts...

[MindFlavor]

Hi @upstream-dmahlberg, I'll leave to @qdm12 to decide what to do on that PR. He's much more competent than me on the subject!

[upstream-dmahlberg]

@MindFlavor @qdm12 Any updates on this?

[qdm12]

Merged, sorry guys for the long delay. I'll try to dig into it in the coming weeks, to improve the CI pipeline.

EDIT: It's merged thanks @micxer so we should have binaries on tags.

[ekeih]

This is awesome, thanks for the work on this! Any chance to get a new tag/release to publish initial binaries? :)

[qdm12]

@micxer it doesn't look like it's building binaries on the latest tag, any clue why? I'm afk for the coming days so I can't really investigate.

[sebastianrakel]

is there any update. would be awesome if this is working, i want to add it to this https://github.com/voxpupuli/puppet-prometheus/ puppet module