mina icon indicating copy to clipboard operation
mina copied to clipboard

Update zkapp permission fallback logic v2

Open glyh opened this issue 3 months ago • 1 comments

This is an alternative to https://github.com/MinaProtocol/mina/pull/18142 Closes https://github.com/MinaProtocol/mina/issues/17852 It differs from that PR in that:

  • [x] No fallback is applied for set_permissions
  • [x] zkapp version is bumped once new verification key is set, and the fallback would be disabled.

The common part of this PR and V1 is that they both implement fallback for access

CI would fail because we've touched on txn snark structure, but I'd like to get some reviews before regenerating them, as it's slow to regenerate.

glyh avatar Dec 03 '25 10:12 glyh

!ci-build-me

glyh avatar Dec 07 '25 05:12 glyh

I haven't fully gone down the rabbit hole, but from what I can tell this solves the issue as I understand it.

martyall avatar Dec 17 '25 22:12 martyall

!ci-build-me

glyh avatar Dec 18 '25 07:12 glyh

It make sense to merge compatible -> develop -> mesa before continuing patching test as I remember some stuff have been moved around.

glyh avatar Dec 18 '25 08:12 glyh

!ci-build-me

glyh avatar Dec 22 '25 05:12 glyh

https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/39916

glyh avatar Dec 22 '25 05:12 glyh

!ci-build-me

glyh avatar Dec 22 '25 07:12 glyh

ff70dfa: this file is not maintained, not tested, and not compiling. For some reason it blows up on my end. So I just comment out the whole file.

I'll get back to this later when we have time.

glyh avatar Dec 22 '25 07:12 glyh

Looks good, there's no more new failing tests. merging.

glyh avatar Dec 22 '25 12:12 glyh