mina icon indicating copy to clipboard operation
mina copied to clipboard

Use rocksdb 10.2.1

Open L-as opened this issue 8 months ago • 8 comments

Compilation stopped working on non-x86 platforms, I assume because the rocksdb in nixpkgs drifted too far away from what Mina expected, and the accidental ABI compatibility broke.

This PR restores it by using 10.2.1 both with and without Nix, reducing the versions of rocksdb used from 3(4?) to 1.

L-as avatar Jun 06 '25 12:06 L-as

10.2.1 haven't entered our OPAM repo. this would at least accompany changes on OPAM's end

That said, I'll try to see if I can work on your work :)

glyh avatar Jun 06 '25 12:06 glyh

It is in the OPAM repo I think. I just checked.

L-as avatar Jun 06 '25 13:06 L-as

https://github.com/o1-labs/opam-repository/tree/677657206d9da47987a4eff8087c1f3a258908f3/packages/rocksdb_stubs/rocksdb_stubs.10.2.1

L-as avatar Jun 06 '25 13:06 L-as

Oh yeah, forgot my colleague cherry-picked my work :)

glyh avatar Jun 06 '25 13:06 glyh

@L-as could you check if PR #17349 would also fix your issue?

georgeee avatar Jun 06 '25 13:06 georgeee

@georgeee That wouldn't fix my issue. I'm using aarch64-linux, and the concrete issue that prompted me to fix this is that seemingly the new rocksdb from nixpkgs (I assume you updated the flake input) now requires liburing, which isn't available in this case.

There are really three possible fixes:

  • What I did here, i.e. port everything to 10.2.1
  • Port only non-x86_64-linux platforms to 10.2.1
  • Go back to old rocksdb that worked from older nixpkgs

L-as avatar Jun 06 '25 14:06 L-as

@georgeee That wouldn't fix my issue. I'm using aarch64-linux, and the concrete issue that prompted me to fix this is that seemingly the new rocksdb from nixpkgs (I assume you updated the flake input) now requires liburing, which isn't available in this case.

Ok, next week I'll try to create a PR that imports rocksdb from older nixpkgs, and I'll ask you to test that

This PR still does too much of a change to be taken

Thanks for taking time to investigate the issue on your side!

georgeee avatar Jun 06 '25 14:06 georgeee

@georgeee I'm pretty sure it would work in that case, but isn't the plan to switch to 10.2.1 anyway?

L-as avatar Jun 06 '25 15:06 L-as

This is already implemented, so no longer needed. Thank you :)

glyh avatar Oct 17 '25 06:10 glyh