mina icon indicating copy to clipboard operation
mina copied to clipboard

Restructure merkle ledger tests

Open glyh opened this issue 9 months ago • 6 comments

Simple noop moving tests around.

glyh avatar Jun 05 '25 09:06 glyh

!ci-build-me

glyh avatar Jun 05 '25 09:06 glyh

!ci-bypass-changelog

georgeee avatar Jun 05 '25 10:06 georgeee

!ci-build-me

georgeee avatar Jun 05 '25 10:06 georgeee

!ci-build-me

dannywillems avatar Jun 09 '25 16:06 dannywillems

@dannywillems I would rewrite this to fit your requirements later :)

glyh avatar Jun 09 '25 17:06 glyh

@dannywillems I would rewrite this to fit your requirements later :)

Ah, thanks! CI fails with

File "src/lib/syncable_ledger/test/dune", line 24, characters 2-21:
24 |   merkle_ledger_tests
       ^^^^^^^^^^^^^^^^^^^
Error: Library "merkle_ledger_tests" not found.
-> required by library "test" in _build/default/src/lib/syncable_ledger/test
-> required by
   _build/default/src/lib/syncable_ledger/test/.test.objs/native/test.cmx
-> required by _build/default/src/lib/syncable_ledger/test/test.a
-> required by alias src/lib/syncable_ledger/test/all
-> required by alias src/lib/default

dannywillems avatar Jun 09 '25 18:06 dannywillems

The build fails because merkle_ledger_tests was removed as a package, but it's still listed as a dependency of the syncable ledger tests:

https://github.com/MinaProtocol/mina/blob/16d0321b99480b5a8e6b664c2adc97bbe56994c1/src/lib/syncable_ledger/test/dune#L24

The syncable ledger tests need access to the Merkle_ledger_tests.Test_stubs, but those are now in merkle_ledger/test/test_stubs.ml. Also, they're not exposed as a library in that new location.

cjjdespres avatar Jul 07 '25 20:07 cjjdespres

Close in favor of https://github.com/MinaProtocol/mina/pull/17486

glyh avatar Jul 07 '25 23:07 glyh