mina icon indicating copy to clipboard operation
mina copied to clipboard

Add Converting Ledger feature with example and tests

Open martyall opened this issue 10 months ago • 1 comments

This is a continuation of https://github.com/MinaProtocol/mina/pull/16853

  • Adds a Converting_merkle_tree module which muxes write requests to a primary_ledger to a converting_ledger, allowing you to apply a pure function convert: primary_ledger.t -> converting_ledger.t before writing to this secondary ledger.
  • Adds a basic configuration type and create method for creating this kind of ledger
  • Adds tests to make sure it is working

NOTE: I created this Account.Unstable.t as an example of how to use this, my understanding is that the actual migrated account type will have similarly trivial changes. Before merging this, we need to specify and implement that.

In a followup PR, we will publicly expose this new Converting_ledger and manage the configration/toggling through the runtime config

martyall avatar May 05 '25 23:05 martyall

After Improving and fixing reformat issues has been merged, make reformat works again as before. Running on my machine after merging compatible shows that the formatting is not good, can you rebase on top of/merge compatible?

dannywillems avatar May 08 '25 08:05 dannywillems

Hey @cjjdespres should we close this?

glyh avatar Jul 28 '25 05:07 glyh

Yes, this was all added in https://github.com/MinaProtocol/mina/pull/16853 and https://github.com/MinaProtocol/mina/pull/17428

cjjdespres avatar Jul 28 '25 12:07 cjjdespres