mina icon indicating copy to clipboard operation
mina copied to clipboard

Deps: bump up dune to 3.18.2

Open dannywillems opened this issue 10 months ago • 7 comments

The reviewer can reproduce it with:

opam install dune.3.18.2
opam switch export opam.export

The output of the first command must upgrade ONLY dune.

dannywillems avatar May 04 '25 07:05 dannywillems

!ci-toolchain-me

dannywillems avatar May 04 '25 07:05 dannywillems

!ci-toolchain-me

dannywillems avatar May 04 '25 09:05 dannywillems

!ci-build-me

dannywillems avatar May 04 '25 09:05 dannywillems

This is a big leap, did you check previously that all dependencies actual support dune 3.18? I think in particular js-of-ocaml has some restriction on dune

glyh avatar May 04 '25 11:05 glyh

!ci-bypass-changelog

dannywillems avatar May 04 '25 11:05 dannywillems

This is a big leap, did you check previously that all dependencies actual support dune 3.18? I think in particular js-of-ocaml has some restriction on dune

Yes. dune should not cause any issue while upgrading.

dannywillems avatar May 04 '25 11:05 dannywillems

If someone wants to take over this patch, nix flake update should be run first, to get rid of the dune build issue in nix.

dannywillems avatar Jun 05 '25 21:06 dannywillems