mina icon indicating copy to clipboard operation
mina copied to clipboard

Introduce additional checks for dhall (deps, dirtyWhen)

Open dkijania opened this issue 4 months ago • 12 comments

Introducing additional checks for dhall which will be used in ci but nothing prevents to use them locally. There are 3 new commands

Additionally I fixed all encountered issues with dirtyWhen and Dependencies

(all commands should be run in buildkite folder)

check dependencies

usage: make check_deps

desc: it validates that if step provides dependsOn section it is a correct and existing key of some job

check dirtyWhen

usage: make check_dirty

desc: it validates that if step provides dirtyWhen section it is corresponding to existing files

print cmd (only for local)

usage: python3 buildkite/scripts/dhall/checker --root buildkite/src/Jobs print-cmd --job MinaArtifactFocal --step build_deb_pkg

EDIT:

Currently there is peculiar issue with running dhall in toolchain:

https://buildkite.com/o-1-labs-2/mina-o-1-labs/builds/35531#01924994-aad4-47bf-a42c-ab8f1d89eaa1/74-99

I will solve it in different PR. As a result won't propagate new Ci jobs

dkijania avatar Oct 01 '24 19:10 dkijania