mina icon indicating copy to clipboard operation
mina copied to clipboard

[Develop] Fix verification in dry runs: alternative take

Open georgeee opened this issue 9 months ago • 3 comments

Fix verification of fork package.

Berkeley version: #15591

Explain how you tested your changes:

  • [x] Mainnet (on #15591): https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/280
  • [x] Devnet (on #15591): https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/281
  • [x] Mainnet dry run (on #15591): https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/282

Checklist:

  • [x] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [x] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [x] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [x] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • [x] All tests pass (CI will check this if you didn't)
  • [x] Serialized types are in stable-versioned modules
  • [x] Does this close issues? None

georgeee avatar May 01 '24 21:05 georgeee

PR also contains upstream merge of berkeley to develop. Only conflict was in MinaArtifact.dhall, due to the fact that hardfork pipeline is not present in develop.

georgeee avatar May 01 '24 21:05 georgeee

!ci-build-me

georgeee avatar May 01 '24 21:05 georgeee

!ci-build-me

georgeee avatar May 02 '24 17:05 georgeee