mina icon indicating copy to clipboard operation
mina copied to clipboard

Fix verification in dry runs: alternative take

Open georgeee opened this issue 9 months ago • 3 comments

Fix verification of fork package.

Explain how you tested your changes:

  • https://buildkite.com/o-1-labs-2/hardfork-package-generation/builds/256

Checklist:

  • [x] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [x] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [x] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [x] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • [x] All tests pass (CI will check this if you didn't)
  • [x] Serialized types are in stable-versioned modules
  • [x] Does this close issues? List them
  • Closes #15577

georgeee avatar Apr 30 '24 16:04 georgeee

!ci-build-me

mrmr1993 avatar Apr 30 '24 18:04 mrmr1993

!approved-for-mainnet

mrmr1993 avatar Apr 30 '24 18:04 mrmr1993

!ci-build-me

deepthiskumar avatar Apr 30 '24 22:04 deepthiskumar

Reviewed change by Jiawei, pushed a tiny fixup to simplify the code

georgeee avatar May 01 '24 14:05 georgeee

!ci-build-me

ghost-not-in-the-shell avatar May 01 '24 17:05 ghost-not-in-the-shell