mina icon indicating copy to clipboard operation
mina copied to clipboard

[berkeley] Remove stop-slots from compile config

Open mrmr1993 opened this issue 9 months ago • 2 comments

This PR removes the stop slots from the compile config.

These caused a previous issue where a release was baked expecting it to use the compile config, where CI is not set up to do so. Instead, we remove the options so that they are only injected in the correct location: in the runtime config that we provide for the network.

mrmr1993 avatar Apr 30 '24 13:04 mrmr1993

!ci-build-me

mrmr1993 avatar Apr 30 '24 13:04 mrmr1993

Is this change necessary in berkeley?

It looks safe and sane, but I'd prefer to avoid any changes to berkeley unless we're confident they're necessary.

As for these changes, I suggest we merge them to develop and on berkeley reject any PR that touches compile configs (including touching the stop slots).

georgeee avatar Apr 30 '24 19:04 georgeee