mina icon indicating copy to clipboard operation
mina copied to clipboard

removing unecessary lru cache for gossip messages in p2p

Open svv232 opened this issue 10 months ago • 10 comments

Explain your changes:

  • Removing redundant caching in the lib2p networking layer.
  • This change deletes the recently_seen field from the Resource_pool.t in transaction_pool.ml. Now the daemon will solely rely on libp2p's networking layer to prevent reprocessing gossip messages.

Explain how you tested your changes:

  • ran ./scripts/mina-local-network/mina-local-network.sh --archive --update-genesis-timestamp --value-transfer-txns --zkapp-transactions to check build and verified block production.

Checklist:

  • [x] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [x] Does this close issues? List them
  • #11704

svv232 avatar Apr 23 '24 00:04 svv232

!ci-build-me

svv232 avatar Apr 23 '24 00:04 svv232

@svv232 please run nightly on this pr (using !ci-nightly-me command) just make sure everything is ok on integration tests

dkijania avatar Apr 23 '24 05:04 dkijania

!ci-build-me

rbonichon avatar Apr 23 '24 07:04 rbonichon

!ci-nightly-me

rbonichon avatar Apr 23 '24 07:04 rbonichon

!ci-nightly-me

svv232 avatar Apr 23 '24 15:04 svv232

!ci-build-me

svv232 avatar Apr 23 '24 15:04 svv232

!ci-build-me

svv232 avatar Apr 24 '24 16:04 svv232

!ci-build-me

svv232 avatar Apr 25 '24 17:04 svv232

!ci-build-me

svv232 avatar Apr 30 '24 15:04 svv232

!ci-build-me

svv232 avatar May 01 '24 17:05 svv232