mina icon indicating copy to clipboard operation
mina copied to clipboard

Migration end at any block

Open ghost-not-in-the-shell opened this issue 10 months ago • 2 comments

Explain your changes: This PR modifies the berkeley_migration app so that it only migrate up to the fork block (instead of migrating all the canonical blocks). And it would mark the blocks after the fork block to be pending so that it's convenient for the berkeley_migration_verifier app to only focus on the canonical blocks up to the fork point

Explain how you tested your changes: I've tested this with umt data

Checklist:

  • [ ] Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • [ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
  • [ ] Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • [ ] Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • [ ] All tests pass (CI will check this if you didn't)
  • [ ] Serialized types are in stable-versioned modules
  • [ ] Does this close issues? List them
  • Closes #0000

ghost-not-in-the-shell avatar Apr 17 '24 18:04 ghost-not-in-the-shell

!ci-build-me

ghost-not-in-the-shell avatar Apr 17 '24 18:04 ghost-not-in-the-shell

!ci-build-me

ghost-not-in-the-shell avatar Apr 17 '24 18:04 ghost-not-in-the-shell

berkeley branch is EOF and we don't need berkeley migration at this point

dkijania avatar Jun 27 '24 19:06 dkijania