mina
mina copied to clipboard
Add payment with valid until and zkapp command with precondition in hard fork test
During hard fork, the following things would be change:
- global slot
- height
- version
global slot
For global slot, the behavior of timed account, payments with valid-until and zkapp-command with global slot precondtion would be affected by the hard fork.
In the existing hard fork integration test, we've already have tested behavior of timed account, we should consider add the test for payments with valid-until and zkapp commands with global slot precondition.
height
Since the code for height is consistent throught out the code (i.e. it's not like global_slot that has global_slot_since_hard_fork). So actually the computation on height would not be affected by hard fork.
version
The version change would directly affect how verification key update works, but since on mainnet we never changed permissions (so they all have the default permission). If we were to have accounts with proof
or impossible
permission for verification key update in the original network, then once the network upgrade to a new version, those permissions would be treated as signature
(it means you can use signature to update their verification key). This behavior is already been tested in the hard fork integration test.
Another things is that if we change the set_verification_key permission of a mainnet account, the txn_version would be upgrade to the current version. It should be impossible to downgrade the version in set_verification_key
permission field.