mina icon indicating copy to clipboard operation
mina copied to clipboard

Figure out what to do with orphaned rosetta PRs

Open mrmr1993 opened this issue 1 year ago • 2 comments

The PRs in question are:

  • https://github.com/MinaProtocol/mina/pull/9544
  • https://github.com/MinaProtocol/mina/pull/9748
  • https://github.com/MinaProtocol/mina/pull/9758
  • https://github.com/MinaProtocol/mina/pull/9760
  • https://github.com/MinaProtocol/mina/pull/9800
  • https://github.com/MinaProtocol/mina/pull/9836
  • https://github.com/MinaProtocol/mina/pull/9879
  • https://github.com/MinaProtocol/mina/pull/10184
  • https://github.com/MinaProtocol/mina/pull/10667

This issue is resolved when we know:

  • whether anything necessary for rosetta is sitting unmerged in these PRs
  • when those things have been reworked and merged
  • when the above PRs have been closed (either as a rework merge, or outright).

mrmr1993 avatar Feb 20 '24 11:02 mrmr1993

#9544 is still relevant and should be reworked and merged. I've created an issue (#15154) to track the implementation of #9748 against the current Rosetta node version. Everything else is either already present in the current main branches or not relevant anymore.

joaosreis avatar Feb 21 '24 10:02 joaosreis

Correction to the above comment, #9544 is against compatible so it was closed as well and another issue (#15155) to track its implementation against current Rosetta node version was created.

joaosreis avatar Feb 21 '24 10:02 joaosreis

All PRs addressed. Closing.

mrmr1993 avatar May 13 '24 05:05 mrmr1993