mina icon indicating copy to clipboard operation
mina copied to clipboard

Update fork config export

Open georgeee opened this issue 1 year ago • 1 comments

Update fork config export functionality in compatible.

If runtime config's entry equals to compile config entry, omit it (that is, set None instead of Some p).

georgeee avatar Feb 08 '24 18:02 georgeee

I don't think we should even export the runtime config data at all. If we have a network that had a runtime config override, that same runtime config override can continue to be run with the new deployment. The runtime config layer is composable, such that you have specify multiple config files together which are merged into one, and this is the workflow we use to provide a build that works on multiple networks (the various network runtime configs get bundled into the docker containers).

I think what the state export should do is only export the 3 lists of accounts for the various ledgers, and export the fork config, and no other data. All downstream tools should only be looking at the compile time config or a manually provided runtime config at most. It doesn't always make sense to take the runtime config from the prior network because we do update the constants between networks, especially in the case of hardforks.

nholland94 avatar Feb 08 '24 18:02 nholland94

An alternative path was taken and this issue is no longer relevant

georgeee avatar Jun 20 '24 16:06 georgeee