mina
mina copied to clipboard
Build docker images using cloud build
Use cloud build for releasing docker images.
Generate cloudbuild.yaml
with dhall, then call google builds submit
Fixes #10693
Need to add dhall-json to the toolchain for CI to work
This PR should be converted to a 'draft' because the CI is entirely red and because the descriptions still says "WIP" on its first line.
Do you have a sense of how to re-use the dhall logic for a simple "docker build" command locally (with some flag to release-docker.sh)?
That's a great suggestion, I'll try to implement it.
@lk86 Done, please re-review if you have time!
PR adding Dhall to toolchain: #11044
As I understand it, this PR offloads docker image creation to google cloud build (which spawns a new VM and uses kaniko to build the dockerfile there).
- What happens if the build is interrupted or preempted? Should a timeout be set?
- Where do logs go?
- What does this cost?
@balsoft Please update this PR with descriptions of why the CI is red and why you are blocked on this.
It's red because of some problem the nature of which escapes me. I'm currently investigating it.
The image BuildKite currently runs on has a pretty old version of the google cloud CLI. I'd first have to figure out how to upgrade that before I can proceed testing out this approach. The reason I'd need to update it, is because the currently installed versions doesn't support the --worker-pool
flag.
What is the status on this @bryanhonof @robinbb
It looks like @bryanhonof worked on this for a while and then stopped. @bryanhonof can answer, and maybe @kantp was involved in de-prioritizing? This is a PR, so if it is not ready for review (and it is not, because the CI is red), then it should be marked draft.
@robinbb @kantp this work has a lot of value to O(1) and last I talked to Bryan and tweag they were making great progress, this is the first I hear that is been de-prioritized. Can we discuss the motivation for that and what direction you are intending to go instead?
I deduced the de-prioritization based on the lack of progress.
I am interested in the same answers as @lk86 .
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me
!ci-build-me