MilhouseVH
MilhouseVH
> Initial entries have no indent. Something within an If-statement or for-loop gets indented. Comments are attached to the code and follow the indent of the code it's commenting on....
> proper quoting when using variable expansion Agreed. I'll add something to that effect. > unneccessary use of githashes: I'm not sure if this is really a coding/style issue, but...
@antonlacon thanks - added reference to `[ test1 -o test2 ]` versus `[[ test1 ]] || [[ test2 ]]`.
`printf` has been used to signal the build stages (`BUILD`, `INSTALL`, `GET` etc.), mainly because it uses a variable level of indentation. The current indentation level (a multiple of `BUILD_INDENT_SIZE`,...
@antonlacon yes, the lack of short-circuiting with `-a` and `-o` could be an issue, and in fact will require that [this logic](https://github.com/LibreELEC/LibreELEC.tv/pull/3098/files#diff-11adfcc768db176527c0e68b697aa119R79) in PR3098 is rewritten as: ``` - if...
@antonlacon I've updated the list to say that the built-in `test` synonym `[]` (ie. `-a` and `-o`) is the _preferred_ syntax, and the extended test syntax (`[[ ]]`/`&&`/`||`) can be...
`screenshot` is listed as an [`Input.Action`](http://kodi.wiki/view/JSON-RPC_API/v6#Input.Action). JSON screenshot: ``` {"jsonrpc": "2.0", "method": "Input.ExecuteAction", "params": {"action": "screenshot"}, "id": 1} ``` There's also the [built-in function](http://kodi.wiki/view/List_of_built-in_functions) `TakeScreenshot`.
It's super frustrating that this missed the cut for the 1.27.0 release - do WIZnet not know the secret handshake to get their stuff adopted? Really not sure what is...
I've tested the following custom 1.27.0 78ff170de9e32c79db6e64d3e33d2bd60002bdcd: builds successfully with this PR. - W5500-EVB-PICO using default native SPI - W5500-EVB-PICO2 using default native SPI - W55RP20-EVB-PICO using default PIO SPI...
Just to add... ``` wiznet6k_send_ethernet: fatal error -5 ``` continues to appear during `NIC.active(True)`. WIZNET5K did the same, so hardly a show stopper. It doesn't appear to be fatal, despite...