docker-phalcon icon indicating copy to clipboard operation
docker-phalcon copied to clipboard

Add PHP 8.0 support

Open MilesChou opened this issue 3 years ago • 12 comments

See https://www.php.net/releases/8.0/en.php

MilesChou avatar Nov 27 '20 03:11 MilesChou

You can already do that. Here is example that we are using for local development: https://github.com/phalcon/cphalcon/blob/master/docker/8.0/Dockerfile

Jeckerson avatar Apr 11 '21 21:04 Jeckerson

Official issue link https://github.com/phalcon/cphalcon/issues/15186

MilesChou avatar Jul 19 '21 13:07 MilesChou

@MilesChou Could you make new Dockerfile's shipped with Phalcon v5.alpha?

Jeckerson avatar Jul 22 '21 08:07 Jeckerson

I try on alpha3

https://github.com/phalcon/cphalcon/tree/v5.0.0alpha3

MilesChou avatar Jul 22 '21 08:07 MilesChou

@Jeckerson Compile work but phalcon.so file load failed.

I don't know why because I just a PHP developer.

https://github.com/MilesChou/docker-phalcon/runs/3132198314?check_suite_focus=true#step:3:45868

MilesChou avatar Jul 22 '21 09:07 MilesChou

Try to use safe folder instead of 64bits.

Jeckerson avatar Jul 25 '21 00:07 Jeckerson

Try to use safe folder instead of 64bits.

Use safe folder but same problem again.

https://github.com/MilesChou/docker-phalcon/runs/3157993047?check_suite_focus=true#step:3:45939

MilesChou avatar Jul 26 '21 05:07 MilesChou

@Jeckerson Solved. Because load Phalcon extension first by default. Adjust the PSR to first and work on Debian and Alpine.

See commit https://github.com/MilesChou/docker-phalcon/pull/50/commits/053496fdc5994aa13bced30c98f39d1b71c0e27f

MilesChou avatar Jul 26 '21 17:07 MilesChou

@MilesChou Could you bump version to RC1 please? And also add PHP8.1.

Jeckerson avatar Jun 06 '22 18:06 Jeckerson

I tried but build failed...

https://github.com/MilesChou/docker-phalcon/runs/6844355654?check_suite_focus=true

MilesChou avatar Jun 11 '22 16:06 MilesChou

I tried but build failed...

https://github.com/MilesChou/docker-phalcon/runs/6844355654?check_suite_focus=true

Seems to work. Btw PSR extension is not required any more since RC1 version.

Jeckerson avatar Jun 12 '22 18:06 Jeckerson

OK, I update code on 8.0 and 8.1 Dockerfile https://github.com/MilesChou/docker-phalcon/actions/runs/2485532716

MilesChou avatar Jun 13 '22 01:06 MilesChou

@MilesChou it seems that it can be closed.

Jeckerson avatar Oct 17 '22 13:10 Jeckerson

Done, Thx @Jeckerson

MilesChou avatar Oct 19 '22 06:10 MilesChou