auto_route_library icon indicating copy to clipboard operation
auto_route_library copied to clipboard

Published 20 hours ago • verified publisher icon Milad-Akarie

[AutoTabsRouter] not working as expected on [web] when `includePrefixMatches` is set to `true`

Open a-h-mzd opened this issue 1 year ago • 15 comments

Steps to reproduce:

  1. Create a simple app with two screens. The second one should have 2 tabs.
  2. Assign these routes to them:
    • /
    • /tabs/tab-1
    • /tabs/tab-2
  3. Set includePrefixMatches to true
  4. Open the app and navigate to the second screen.
  5. Navigate to the second tab.
  6. Press the back/forward button on the browser to see the issue.

Expected behavior

The browser back button should change the tabs just like when includePrefixMatches is set to !kIsWeb.

Actual behavior

The address bar changes but there are no navigations between tabs.

Screen record

https://github.com/Milad-Akarie/auto_route_library/assets/42738288/7aa795e8-f4a5-467d-ad76-a772edf8edcb

Versions:

flutter: 3.10.6 auto_route: 7.7.1 auto_route_generator: 7.2.0

a-h-mzd avatar Aug 01 '23 09:08 a-h-mzd

@a-h-mzd in your video I'm seeing tabs/tabs-1 where is the 's' coming from? your defined route is tabs/tab-1

Milad-Akarie avatar Aug 03 '23 13:08 Milad-Akarie

@Milad-Akarie That was a typo! 😀

a-h-mzd avatar Aug 03 '23 14:08 a-h-mzd

@Milad-Akarie, Any news on this issue?

a-h-mzd avatar Aug 10 '23 14:08 a-h-mzd

@Milad-Akarie This is blocking us from going live. Isn't there any estimation on when this is going to be fixed?

a-h-mzd avatar Sep 15 '23 10:09 a-h-mzd

@a-h-mzd could you create a repo that reproduces this behavior?

Im swamped with work these days and have no free time at all, let's hope this is a minor fix

Milad-Akarie avatar Sep 15 '23 10:09 Milad-Akarie

@Milad-Akarie Sure. Thanks, BTW. 🤍

a-h-mzd avatar Sep 15 '23 10:09 a-h-mzd

@Milad-Akarie You can find the minimum working version of the issue here: https://github.com/a-h-mzd/flutter-test

a-h-mzd avatar Sep 15 '23 10:09 a-h-mzd

@Milad-Akarie did the minimum working version work for you? did it help?

a-h-mzd avatar Oct 06 '23 11:10 a-h-mzd

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

github-actions[bot] avatar Nov 06 '23 08:11 github-actions[bot]

Commenting to remove the no-issue-activity tag.

a-h-mzd avatar Nov 06 '23 12:11 a-h-mzd

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions

github-actions[bot] avatar Dec 07 '23 08:12 github-actions[bot]

@Milad-Akarie Is there any update on this issue?

a-h-mzd avatar May 02 '24 12:05 a-h-mzd