sd-webui-controlnet icon indicating copy to clipboard operation
sd-webui-controlnet copied to clipboard

Move models to models/ControlNet

Open missionfloyd opened this issue 2 years ago • 4 comments

I wasn't sure what (if anything) to do with the config files, so I left them where they are.

Fixes #45 Fixes #127

missionfloyd avatar Feb 17 '23 05:02 missionfloyd

I think it would be a good idea to additionally update the readme, as otherwise the guidance on where to place the models will be misleading.

ljleb avatar Feb 17 '23 10:02 ljleb

missing leres, that was added yesterday

btw from my understanding from this, it would create a folder ControlNet-Annotator in models,

i dont think thats the best option, instead, IMO would be better to create individual folders for each of those models, some are already used by other extensions, midas and leres are already used by https://github.com/thygate/stable-diffusion-webui-depthmap-script

that way it would avoid downloading those multiple times, ofc other extensions can use models under ControlNet-Annotator,

(my current models folder) folders

but thats kinda non written rule, in that case follow what has been done before, ControlNet models are specific to this extension, but the other ones can also be used by others, in fact i believe it will open opportunity for development of extensions like draw by words, etc and those models would be already in place as ControlNet is quite popular and useful

brunogcar avatar Feb 18 '23 18:02 brunogcar

I was wondering if there was a better place for them. If separate folders makes more sense, let's do that.

How's that? https://github.com/Mikubill/sd-webui-controlnet/pull/138/commits/453424fe214f3f4589066cf0632a7027d4748585

missionfloyd avatar Feb 18 '23 22:02 missionfloyd

those models predate ControlNet , that file structure made logic when it was a standalone project, but now its on a framework that shares resources, IMO now makes more sense to place them in root models folder

we all know how powerful controlnet is and how it will influence future development, so it would be a good chance to set standards and examples

newest commit seems good to me, that closes https://github.com/Mikubill/sd-webui-controlnet/issues/45

brunogcar avatar Feb 18 '23 22:02 brunogcar

Also close #127 #129. Thanks for your contribution!

Mikubill avatar Feb 22 '23 14:02 Mikubill